Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI/CD: Add build GitHub Actions workflows #53

Merged
merged 77 commits into from
May 24, 2024
Merged

CI/CD: Add build GitHub Actions workflows #53

merged 77 commits into from
May 24, 2024

Conversation

patrickpa
Copy link
Contributor

@patrickpa patrickpa commented May 22, 2024 •
edited
Loading

Description

This PR adds GitHub Actions workflows to automatically trigger build on PRs and merges (target branch commit from PR).

The workflows added here trigger only if any change is done on the source code:

...
paths: # we only include paths critical for building to avoid unnecessary runs
      - src/**
      - include/**
      - scripts/cmake/**
...

How was the PR tested?

  1. Add workflow for Linux build
  2. Add workflow for Windows build

Notes

  • The current version of the workflow only builds the software, it does not publish any artifact for user to use after the workflow is done.
  • The current version has the dependencies installation directly in the workflow. For future improvement, we can package it on Docker images and use the container option to only execute the software build.

@patrickpa
Fix typo on dev_essential
202cb9e 
Signed-off-by: Patrick Abrahão <[email protected]>
@patrickpa
Add cmake to workflow
f41b861 
Signed-off-by: Patrick Abrahão <[email protected]>
@patrickpa
Fix cmake script execution
bbd362c 
Signed-off-by: Patrick Abrahão <[email protected]>
@patrickpa
Add directly whoami to build
681883b 
Signed-off-by: Patrick Abrahão <[email protected]>
@patrickpa
Remove cmake to test user path
3b0ef44 
Signed-off-by: Patrick Abrahão <[email protected]>
@patrickpa
Fix import on file on the fly
89dc4e9 
Signed-off-by: Patrick Abrahão <[email protected]>
@patrickpa
Remove rm on temp
70701af 
Signed-off-by: Patrick Abrahão <[email protected]>
@patrickpa
Add initial windows workflow
3713f2d 
Signed-off-by: Patrick Abrahão <[email protected]>
@patrickpa
Fix print command
bf992b3 
Signed-off-by: Patrick Abrahão <[email protected]>
@patrickpa
Fix toString option
b90a191 
Signed-off-by: Patrick Abrahão <[email protected]>
@patrickpa
Fix type on set dll
e0ac2f0 
Signed-off-by: Patrick Abrahão <[email protected]>
@patrickpa
Proper convert path to string
03c69d8 
Signed-off-by: Patrick Abrahão <[email protected]>
@patrickpa
Remove temp branch from actions
42f15f6 
Signed-off-by: Patrick Abrahão <[email protected]>
@patrickpa patrickpa marked this pull request as ready for review May 24, 2024 08:27
hoangtungdinh
hoangtungdinh approved these changes May 24, 2024
View reviewed changes
Copy link
Collaborator

@hoangtungdinh hoangtungdinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work, thanks @patrickpa

@hoangtungdinh hoangtungdinh merged commit 6f61b80 into develop May 24, 2024
3 checks passed
@hoangtungdinh hoangtungdinh deleted the patrick/add_cicd_actions_workflows branch May 24, 2024 08:45
hoangtungdinh pushed a commit that referenced this pull request Jun 4, 2024
@patrickpa @hoangtungdinh
CI/CD: Add build GitHub Actions workflows (#53)
5596abf 
Signed-off-by: Patrick Abrahão <[email protected]>
@hoangtungdinh hoangtungdinh mentioned this pull request Jun 4, 2024
Merged
hoangtungdinh pushed a commit that referenced this pull request Jun 5, 2024
@patrickpa @hoangtungdinh
CI/CD: Add build GitHub Actions workflows (#53)
de88829 
Signed-off-by: Patrick Abrahão <[email protected]>

Signed-off-by: Patrick Abrahão <[email protected]>
hoangtungdinh pushed a commit that referenced this pull request Jun 5, 2024
@patrickpa @hoangtungdinh
CI/CD: Add build GitHub Actions workflows (#53)
08977d1 
Signed-off-by: Patrick Abrahão <[email protected]>

Signed-off-by: Patrick Abrahão <[email protected]>
hoangtungdinh pushed a commit that referenced this pull request Jun 5, 2024
@patrickpa @hoangtungdinh
CI/CD: Add build GitHub Actions workflows (#53)
d6029b4 
Sign off:

Signed-off-by: Patrick Abrahão <[email protected]>

Signed-off-by: Patrick Abrahão <[email protected]>
pmai pushed a commit that referenced this pull request Jun 6, 2024
@patrickpa @pmai
CI/CD: Add build GitHub Actions workflows (#53)
7795c56 
Signed-off-by: Patrick Abrahão <[email protected]>
Signed-off-by: Patrick Abrahão <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoangtungdinh hoangtungdinh hoangtungdinh approved these changes

@romanodanilo romanodanilo Awaiting requested review from romanodanilo

Assignees
No one assigned
Labels
None yet
Projects
Quality Checker
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@patrickpa @andreaskern74 @hoangtungdinh